fix(explorer): exclude approval events from Total column#600
Merged
Conversation
ERC20 Approval events were being counted as value transfers in the Total column, inflating the displayed amount. For example, a tx with approve(1 USDC) + deposit(1 USDC) showed $2 instead of $1. Approvals grant spending permission — no tokens are moved — so they should not contribute to the total value sum.
Bundle Size Report
Chunk changes (>1KB)
Compared against main branch (baseline from 2/4/2026, 5:13:51 PM) |
Cloudflare Deployments
|
o-az
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ERC20
Approvalevents were being counted as value transfers in the Total column on the address transaction list. For example, a transaction withapprove(1 USDC)+deposit(1 USDC)showed $2 instead of $1.Approvals grant spending permission — no tokens are moved — so they should not contribute to the total value sum.
Fix
Filter out events with
type === 'approval'before extractingamountparts for the Total calculation. Applied in both:TransactionTotalCellin\$address.tsx(server-enriched path)TransactionTotalinTxTransactionRow.tsx(client-enriched/token path)Before / After